-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use textarea for providing checkbox options #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia1
force-pushed
the
feat/use-textarea-for-checkbox-options
branch
from
January 3, 2021 07:07
0cb0bb5
to
8c530bc
Compare
karrui
reviewed
Jan 5, 2021
tshuli
reviewed
Feb 9, 2021
src/public/modules/forms/admin/controllers/edit-fields-modal.client.controller.js
Outdated
Show resolved
Hide resolved
tshuli
reviewed
Feb 9, 2021
Co-authored-by: tshuli <[email protected]>
karrui
force-pushed
the
feat/use-textarea-for-checkbox-options
branch
from
February 17, 2021 02:10
8530dce
to
2077676
Compare
karrui
changed the title
Use textarea for Checkbox options
feat: use textarea for providing checkbox options
Feb 17, 2021
karrui
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We may expect users to have many Checkbox options and adding them one-by-one to FormSG is troublesome. As such, we want Checkbox options to follow Dropdown options so that Checkbox options can be edited by a
textarea
with each option in each line in thetextarea
.Closes #743
Solution
Only frontend changes. Edit the conditional rendering (i.e.
ng-if
) such that Dropdown and Checkbox show the sametextarea
for Options and Radio button will show its usual one-by-one options.In the controller, edit the
if
clauses so that we now transformfieldOptions
intofieldOptionsFromText
when rendering Options and we check forfieldOptionsFromText
instead ofmanualOptions
when savingfieldOptions
.Before & After Screenshots
BEFORE:
AFTER:
Note: I have not checked for test breakages yet.