feat: add FIXED_LINE_OR_MOBILE numbers to pass homeno validation #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how was this discovered again? |
syan sent me an email from a form admin asking why office numbers don't work on a home number field |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some legit office landline numbers are being marked as invalid due to not being labeled as FIXED_LINE numbers by google's libphonenumber, but as FIXED_LINE_OR_MOBILE. This PR loosens the homeno validation to allow for the latter type.
Solution
Features:
Before & After Screenshots
BEFORE:
AFTER: