refactor: migrate preview admin form endpoint to Typescript #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
approved these changes
Dec 16, 2020
# Conflicts: # src/app/modules/form/admin-form/__tests__/admin-form.controller.spec.ts
|
Rerequesting review since the extraction of form instance method was slightly more complex than it seemed (and also upped the robustness of the public form view; now it ensures the form is populated before returning the public view) |
mantariksh
approved these changes
Dec 21, 2020
liangyuanruo
suggested changes
Dec 21, 2020
…View step" This reverts commit 872e3ca.
No need anymore, use model function directly
|
Ready for rereview |
|
Closing this PR for the time being until @karrui 's involvement on other project is reduced. |
# Conflicts: # src/app/modules/form/__tests__/form.utils.spec.ts # src/app/modules/form/form.utils.ts # src/app/modules/submission/email-submission/email-submission.service.ts
liangyuanruo
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
I notice the consistent use of getPublicView() which is great, so let's create a new interface in order to embed that consistency:
interface PublicView<T> {
getPublicView(): T
}
interface IAgencySchema extends IAgency, Document, PublicView<PublicAgency> {...}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Migrates
:formId/adminform/previewendpoint to Typescript.The choice of public fields to display is now in each database model's domain; see:
UserModel.getPublicViewAgencyModel.getPublicViewFormModel.getPublicViewSolution
Features:
Tests
Controller tests have been added.
add tests for FormModel#getPublicView instance method
add tests for FormSvc#getFormPublicView