Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: misc UX fixes #833

Merged
merged 4 commits into from
Dec 9, 2020
Merged

feat: misc UX fixes #833

merged 4 commits into from
Dec 9, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Dec 9, 2020

Problem

A bunch of small UX fixes.
Closes #571

Solution

Improvements:

  • feat: change storage mode form typed declaration from "i understand the consequences and have stored my secret key in 2 other places" to a simpler "I have shared my secret key with a colleague"
  • remove verified toast on secret key verification success so only one success toast shows on activation
  • feat: update storage mode guide link styling to not include the parenthesises
  • feat: add spacing between each email in email form email list

Before & After Screenshots

BEFORE:

Initial load has no spacing

Screenshot 2020-12-09 at 2 08 57 PM
Original text
Screenshot 2020-12-09 at 2 10 25 PM

Two toasts on storage activation
Screenshot 2020-12-09 at 2 11 41 PM

Link to guide includes parenthesis
Screenshot 2020-12-09 at 2 13 28 PM

AFTER:

Initial load now separates emails by a space.
Screenshot 2020-12-09 at 2 07 58 PM

Shorter storage mode confirmation text
Screenshot 2020-12-09 at 2 10 54 PM

SIngle toast on storage activation
Screenshot 2020-12-09 at 2 12 18 PM

Link to guide now excludes the parenthesis
Screenshot 2020-12-09 at 2 12 51 PM

Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karrui karrui merged commit 6d20e1f into develop Dec 9, 2020
@karrui karrui deleted the feat/ux-fixes branch December 9, 2020 07:52
@mantariksh mantariksh mentioned this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ux fixes
2 participants