Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve email mode messaging #825

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Dec 8, 2020

Problem

This PR finally closes the first issue created in this repo.

Closes #1

Solution

Features:
Settings page

  • when only 1 recipient email is entered, display "Recommended: at least 2 recipients to prevent response loss from bounced emails" info box.
  • update 'Read about email reliability' link to Guarding against bounces' with new valid link
  • change the toaster under 'authentication' to say 'Deactivate your form to change authentication method'

Create form modal

  • amend copy of email mode slightly to "...Not recommended usually, especially for high volume forms...

Activation Email mode only

  • New toaster messaging for email mode form activation that lasts for 10 seconds with link to autoarchive help.
  • update deactivation toast messaging

Before & After Screenshots

BEFORE

Create form (Display text on only 1 email, new link and text, new discouragement copy)
Screenshot 2020-12-09 at 10 17 44 AM
Settings page (Display text on only 1 email, new link and text)
Screenshot 2020-12-09 at 10 19 54 AM
Settings page (new deactivation messaging)
Screenshot 2020-12-09 at 10 26 36 AM
Activation and deactivation text
Both have same text
Screenshot 2020-12-09 at 10 31 55 AM

AFTER

Create form (Display text on only 1 email, new link and text, new discouragement copy)
Screenshot 2020-12-09 at 10 16 38 AM
Settings page (Display text on only 1 email, new link and text)
Screenshot 2020-12-09 at 10 18 57 AM
Settings page (new deactivation messaging)
Screenshot 2020-12-09 at 10 25 36 AM

Activation and deactivation text
Screenshot 2020-12-09 at 10 31 12 AM
Screenshot 2020-12-09 at 10 31 37 AM


const err = checkForErrors(String(emails).split(','))
$scope.$watch('vm.formData.emails', (newEmails) => {
vm.emailInfoMsg =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding a custom $watch, might it be better to add this logic in checkForErrors or vm.validateEmails? Then at least all the code which runs on changes to the emails input is all in one place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want the initial load to also show the info message. Since vm.validateEmails only run on change, it is not suitable. I also tried just assigning to vm.emailInfoMsg directly, but vm.formData.emails may be undefined at the start and won't get updated when formData.email finally gets populated.

@karrui karrui merged commit 3fb105d into develop Dec 9, 2020
@karrui karrui deleted the feat/improve-email-msging branch December 9, 2020 06:06
@mantariksh mantariksh mentioned this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Email mode messaging (smol ticket)
2 participants