ref: migrate create new form api flow to TypeScript #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difference from just calling Form.create is that it forces the admin form schema parameter to be a string
remove the old function, update existing "integration" tests to use the new handler
mantariksh
approved these changes
Dec 7, 2020
# Conflicts: # src/app/routes/admin-forms.server.routes.js
# Conflicts: # src/app/modules/form/admin-form/__tests__/admin-form.controller.spec.ts # src/app/modules/form/admin-form/__tests__/admin-form.service.spec.ts # src/app/modules/form/admin-form/admin-form.controller.ts # src/app/modules/form/admin-form/admin-form.service.ts # src/app/routes/admin-forms.server.routes.js # src/types/form.ts
(missed during rebase)
|
Please rereview since I've merged develop in! |
mantariksh
approved these changes
Dec 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR migrates the domain layers pertaining to
POST /adminformendpoint.Additionally, a new utility function
transformMongoErroris written, to transform errors thrown by mongo into ApplicationErrors understood by our application.Solution
Features:
POST /adminformcreateFormservice functionhandleCreateFormhandler functiontransformMongoErrorutility function to transform errors thrown by mongo intoApplicationErrorsunderstood by our applicationhandleCreateFormcontroller functionTests
Add tests for all new methods. Note that there are still no integration tests as the router has not been migrated to TypeScript.