fix(workflow): set approval toggle header size to h4 #8010
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
changed the title
KenLSM
changed the title
scottheng96
approved these changes
Dec 18, 2024
scottheng96
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Background
Approval toggle header is a size smaller than headers of similar hierarchy. We previously dropped this as it was not blocking the release.
After some thinking, and consideration that we're likely to conclude with MRF admins features (i.e., not going to add more configurations), we should treat the Approval toggle to be the only header, and thus promote it to be of the same hierarchy.
Closes FRM-1916
Solution
Set Approval toggle header to be of the same size as other header-level text (h4).
Breaking Changes
Before & After Screenshots