Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to react email, update copy #7985

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Dec 11, 2024

Problem

Closes FRM-1918

Solution

  1. Update copy
  2. Move ejs to render as react component
  3. Added storybook

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Component Before After
Email Template Screenshot 2024-12-11 at 11 22 22 AM Screenshot 2024-12-11 at 11 20 31 AM

Tests

Regression

Email address OTP verification should be received by user

  • Create an admin form
  • Add email address and enable verification
  • Trigger email verification
  • Ensure that email is received

Copy link

linear bot commented Dec 11, 2024

@KenLSM KenLSM force-pushed the feat/otp-email-verification-update branch from 5fb4af2 to 9f58489 Compare December 11, 2024 03:08
@KenLSM KenLSM force-pushed the feat/otp-email-verification-update branch from 9f58489 to 3147f36 Compare December 11, 2024 03:16
@datadog-opengovsg
Copy link

Datadog Report

Branch report: feat/otp-email-verification-update
Commit report: 3147f36
Test service: formsg

✅ 0 Failed, 1332 Passed, 1 Skipped, 3m 43.05s Total duration (3m 6.42s time saved)

@KenLSM KenLSM merged commit 6d929a8 into develop Dec 11, 2024
18 of 20 checks passed
@KenLSM KenLSM deleted the feat/otp-email-verification-update branch December 11, 2024 07:59
@KenLSM KenLSM mentioned this pull request Dec 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants