feat: mfb v1.1 accept-deny re-prompt #7959
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin9foong
force-pushed
the
feat/mfb-v1.1
branch
from
6187c37 to
8a68323
Compare
Datadog ReportBranch report: ✅ 0 Failed, 119 Passed, 0 Skipped, 27.84s Total duration (6m 32.39s time saved) |
kevin9foong
had a problem deploying
to
staging-alt2
GitHub Actions
Failure
kevin9foong
had a problem deploying
to
staging-alt2
GitHub Actions
Failure
kevin9foong
force-pushed
the
feat/mfb-v1.1
branch
from
dc41d3a to
89a3f1c
Compare
|
Pending unit test for:
Pending chromatic story for:
note: did not write chromatic stories for the highlighted fields indicating accept/deny pending due to difficulties providing decorators for contexts/providers around the component. |
kevin9foong
temporarily deployed
to
staging-alt2
GitHub Actions
Inactive
|
Since can re-prompt, update form metadata to store # of prompts made per form to track volume of usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With MFB v1.0, admins are unable to re-try a prompt if they do not like the results from the initial prompt without recreating a new form or deleting all fields.
This is since when a form is generated using MFB prompt, the fields are created and MFB button disappears as it does not show up when fields exist for a form.
Closes FRM-1925
Solution
Allow admins to accept or reject proposed changes generated by Magic Form Builder.
Breaking Changes
No - this PR is backwards compatible
Before & After Screenshots
BEFORE:
AFTER:
New MFB button placement
New popover prompt
Fields generated indicated in bounding box and accept/deny popover
Tests