Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.155.0 #7816

Merged
merged 6 commits into from
Oct 29, 2024
Merged

build: release v6.155.0 #7816

merged 6 commits into from
Oct 29, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Oct 29, 2024 •
edited
Loading

New

  • feat: move step1 email field to settings #7794
  • chore: remove legacy routes #7810
  • feat(singpass): singpass jwks config #7809
  • build: merge release v6.154.0 to develop #7808
  • fix(config): default S3 endpoint with region #7807

Tests

feat: move step1 email field to settings #7794

TC1: Selecting step 1 email field sends completion email to step 1 email response value:

  • Create MRF with email field
  • Create 2 steps
  • Add email field to step 1 of workflow
  • Go to email notifications settings page
  • Add step 2 to notify other respondents
  • Add the email field to step 1 email field
  • Add other parties static emails
  • Complete the mrf flow
  • Assert that email is sent to all parties (this includes step 1 email selected, step 2 email and static emails)

TC2: Selecting step 1 email field sends approve/reject email to step 1 email response value:

  • From TC1
  • Make step 2 an approval step with yes, no field
  • Approve / reject the workflow and verify the email is sent to all parties (this includes step 1 email selected, step 2 email and static emails)

TC3: Deleting the email field causes email to not send to that step 1 party anymore

  • From TC2
  • Delete the email field selected previously
  • Complete the MRF workflow
  • Verify that step 2 email and static emails receive the outcome but there is no email for the previous step 1 email (since the email field has been deleted)

feat(singpass): singpass jwks config #7809

Regression

Singpass login should still work

  • Create a storage mode form with Singpass (login)
  • As a respondent, login with singpass
  • Observe that you are successfully redirect to Singpass Login
  • Observe that you are redirected back to the form after login
  • Observe that you can submit the form

LoneRifle and others added 6 commits October 28, 2024 11:56
@LoneRifle
fix(config): default S3 endpoint with region (#7807)
26a391d 
`AWS_ENDPOINT` defaults to an S3 endpoint hard-coded to ap-southeast-1.
This affects deployment scenarios to other AWS regions, unless
`AWS_ENDPOINT` is specified to line up with `AWS_REGION`.

It can be argued that the default for `AWS_ENDPOINT` should be driven
by the specific region that FormSG is deployed to, so accordingly, at
runtime, change `loadBucketS3UrlSchema()` so that the default endpoint
for S3 buckets reflects the region where FormSG is currently deployed.
@KenLSM
Merge pull request #7808 from opengovsg/release-al2
e17afae 
build: merge release v6.154.0 to develop
@KenLSM
feat(singpass): singpass jwks config (#7809)
64e7d82 
* feat: capture and redirect on sp on well-known endpoint

* chore: global replacement
@KenLSM
chore: remove legacy routes (#7810)
f4a1eed
@kevin9foong
feat: move step1 email field to settings (#7794)
4434cef 
* feat: add onblur to single select component

* feat: add single select to email notifications page

* feat: add separate notify or step 1 in mrf send outcome email logic

* feat: remove email field in step 1 of workflow builder

* fix: add ChangeHandler

* feat: remove validation in FE to account for deleted email field id

* feat: add tc for step 1 field

* feat: add chromatic tc for step 1 in settings page

* chore: remove unused import

* fix: onBlur typing

* feat: add default for emailFieldNotificationId
@KenLSM
chore: bump version to v6.155.0
a88b028
@kennethchangOPENGOV
Copy link

  • "Notify Respondent in Step 1" => "Notify respondent in step 1"

  • Tests for feat: move step1 email field to settings successful

@KenLSM KenLSM enabled auto-merge October 29, 2024 08:11
kennethchangOPENGOV
kennethchangOPENGOV approved these changes Oct 29, 2024
View reviewed changes
Copy link

@kennethchangOPENGOV kennethchangOPENGOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KenLSM KenLSM merged commit 1064a2c into release-al2 Oct 29, 2024
51 of 53 checks passed
@KenLSM KenLSM deleted the release_v6.155.0 branch October 29, 2024 08:47
@KenLSM KenLSM mentioned this pull request Oct 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennethchangOPENGOV kennethchangOPENGOV kennethchangOPENGOV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KenLSM @kennethchangOPENGOV @LoneRifle @kevin9foong