Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.30.2 - fix AWS endpoint and /emailnotifications log group #78

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Aug 5, 2020

Problem

  1. In the current release, logs from our /emailnotifications endpoint are going to the main log group instead of the custom log group formsg-email-notifications-production. This means that our bounce alarms are on the wrong log group, and email logs are being stored for a year instead of a week as intended.

  2. An extra trailing / was introduced to the AWS endpoint during the TypeScript migration, breaking all image, logo and attachment uploads and downloads.

Solution

  1. The problem was that during the TypeScript migration for src/config/logger, the AWS and CloudWatch environment variables were modified to be imported from config instead of taken directly from process.env. This caused them to be undefined because config depends on logger, resulting in a circular dependency. The solution is to get the env vars directly from process.env instead of importing them from config.

  2. Removing the trailing /.

@mantariksh mantariksh requested a review from karrui August 5, 2020 04:22
@mantariksh mantariksh changed the title Release 4.30.2 - fix /emailnotifications log group Release 4.30.2 - fix AWS endpoint and /emailnotifications log group Aug 5, 2020
@mantariksh
Copy link
Contributor Author

mantariksh commented Aug 6, 2020

@mantariksh

  • Create and submit an email mode form with all basic form fields
  • Create and submit a storage mode form with all basic form fields

@mantariksh
Copy link
Contributor Author

mantariksh commented Aug 6, 2020

@karrui

  • Create and submit a form with all MyInfo fields
  • Test form duplication, field reordering, field duplication, field editing

@mantariksh
Copy link
Contributor Author

mantariksh commented Aug 6, 2020

@arshadali172

  • On intranet IE11, check image upload, logo upload, storage mode attachment submission and download

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantariksh mantariksh merged commit 95423a7 into release Aug 11, 2020
@liangyuanruo liangyuanruo deleted the release-4.30.2 branch January 6, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants