Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tighten gstatic.cn csp config #7666

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: tighten gstatic.cn csp config #7666

merged 1 commit into from
Sep 11, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Sep 11, 2024 •
edited
Loading

Problem

gstatic.cn was added back in as it broke recaptcha for users in CN. However, this re-introduced an issue where the csp domain is too wide.

Closes FRM-1853

Solution

Tighten CSP gstatic.cn domain

Breaking Changes

  • No - this PR is backwards compatible

@KenLSM KenLSM requested a review from kevin9foong September 11, 2024 08:21
@KenLSM KenLSM merged commit c3e70a0 into develop Sep 11, 2024
23 checks passed
@KenLSM KenLSM deleted the fix/csp-gstatic branch September 11, 2024 08:38
@KenLSM KenLSM mentioned this pull request Sep 11, 2024
Merged
@linear Linear
Copy link

linear bot commented Sep 12, 2024

FRM-1853 GTA-10-001/002 WP1: Remove GTM and gstatic from CSP headers (Repeat finding)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin9foong kevin9foong kevin9foong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @kevin9foong