Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate validate- and receiveEmailSubmission to TypeScript #755

Merged
merged 33 commits into from
Dec 9, 2020
Merged

refactor: migrate validate- and receiveEmailSubmission to TypeScript #755

merged 33 commits into from
Dec 9, 2020

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Nov 30, 2020 •
edited
Loading

This PR migrates validateEmailSubmission and receiveEmailSubmission to TypeScript.

Tests

  • Submit an email mode form with an email field with autoreply, as well as multiple attachments with the same filename. Check that the attachment filenames are de-duplicated in both the admin response and the email confirmation.

@mantariksh mantariksh force-pushed the ref/ts-email-subs-busboy branch from ac6ec23 to 524f05b Compare November 30, 2020 09:59
@mantariksh mantariksh marked this pull request as ready for review November 30, 2020 10:02
@mantariksh mantariksh force-pushed the ref/ts-email-subs-prepare branch from 861a48e to 5e8ccc5 Compare December 1, 2020 13:01
@mantariksh mantariksh force-pushed the ref/ts-email-subs-busboy branch from 524f05b to 941e349 Compare December 1, 2020 14:21
@mantariksh mantariksh mentioned this pull request Dec 1, 2020
Merged
@mantariksh mantariksh force-pushed the ref/ts-email-subs-prepare branch from 7df99e9 to d0d6aca Compare December 2, 2020 03:09
@mantariksh mantariksh force-pushed the ref/ts-email-subs-busboy branch from 941e349 to c11f660 Compare December 2, 2020 03:14
@mantariksh mantariksh requested review from karrui and tshuli and removed request for karrui December 2, 2020 03:15
karrui
karrui approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew. lgtm

src/app/modules/submission/email-submission/email-submission.middleware.ts Outdated Show resolved Hide resolved
src/app/modules/submission/email-submission/email-submission.middleware.ts Outdated Show resolved Hide resolved
src/app/modules/submission/email-submission/email-submission.middleware.ts Outdated Show resolved Hide resolved
src/app/modules/submission/email-submission/email-submission.receiver.ts Show resolved Hide resolved
src/app/modules/submission/email-submission/email-submission.util.ts Show resolved Hide resolved
@mantariksh mantariksh force-pushed the ref/ts-email-subs-prepare branch from 177ec12 to e03f926 Compare December 7, 2020 07:51
@mantariksh mantariksh force-pushed the ref/ts-email-subs-busboy branch from 9f35e27 to c01dac6 Compare December 7, 2020 09:17
@mantariksh mantariksh changed the base branch from ref/ts-email-subs-prepare to develop December 7, 2020 09:17
@mantariksh
Copy link
Contributor Author

don't merge yet, need to make improvements to the tests

@mantariksh mantariksh mentioned this pull request Dec 8, 2020
Merged
@mantariksh
Copy link
Contributor Author

@karrui re-requesting your review for commit ba61d14 pls!

@mantariksh mantariksh requested a review from karrui December 8, 2020 05:05
@mantariksh
ref: return obj from hashSubmission
0b05c92
@mantariksh
ref: log hash and add req.attachments
0082547
@mantariksh
ref: use new receiveEmailSubmission
aa932b8
@mantariksh
ref: use new validateEmailSubmission
1dccd6e
@mantariksh
ref: implement mapRouteError
38bec37
@mantariksh
fix: add async and return to middlewares
63888d7
@mantariksh
test: add fieldId to checK
ec77960
@mantariksh
fix: assign parsed to body property
56cf831
@mantariksh
test: fix rest of jasmine tests
c363d74
@mantariksh
ref: merge util and utils
a4c670a
@mantariksh
test: remove attachment spec
7564191
@mantariksh
ref: explicitly add req key
09b1e2f
@mantariksh
docs: add jsdocs for service
91f7eac
@mantariksh
docs: add docs for receiver
e3e596e
@mantariksh
ref: type validateSubmission body properly
e043a42
@mantariksh
ref: use mapRouteError for validate middleware
98e3901
@mantariksh
test: add tests for validate- and receiveEmailSubmission (#773)
a1e9353 
* test: move attachment spec to email-submission.util

* test: add tests for validateAttachments

* test: add test for hashSubmission

* test: add receiver tests
@mantariksh
feat: install form-data
f5fa486
@mantariksh
test: improve configureMultipartReceiver tests
18dc7ba
@mantariksh
fix: resolve Promise only if body is defined
65fb75b
@mantariksh
test: add error scenarios
993cfa1
@mantariksh
ref: add else case if body is undefined
945511c
@mantariksh mantariksh force-pushed the ref/ts-email-subs-busboy branch from 72b4967 to 945511c Compare December 8, 2020 09:00
@mantariksh
Copy link
Contributor Author

don't merge before we figure out why large attachments are crashing staging

@mantariksh mantariksh merged commit b085e5b into develop Dec 9, 2020
@mantariksh mantariksh mentioned this pull request Dec 10, 2020
Merged
@liangyuanruo liangyuanruo deleted the ref/ts-email-subs-busboy branch January 26, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshuli tshuli Awaiting requested review from tshuli

@karrui karrui Awaiting requested review from karrui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mantariksh @karrui