Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add simple fix to date format for sample form submission api #7539

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

m0nggh
Copy link
Contributor

@m0nggh m0nggh commented Jul 18, 2024

Problem

Data from the sample form submission API are not in the correct format.

Date field should return the day in 2-digit format to standardise with formSG date format.

Solution

Date field to return day as '2-digit'

Breaking Changes

  • No - this PR is backwards compatible

Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@KenLSM KenLSM merged commit 59d59de into develop Jul 18, 2024
22 checks passed
@KenLSM KenLSM deleted the chore/sample-form-submission/modify-date-format branch July 18, 2024 12:45
Copy link
Contributor Author

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@KenLSM KenLSM mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants