Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reddot on email noti #7463

Merged
merged 2 commits into from
Jul 5, 2024
Merged

feat: add reddot on email noti #7463

merged 2 commits into from
Jul 5, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jul 2, 2024 •
edited
Loading

Problem

Closes FRM-1747

Solution

Adds reddot on Admin Form Settings > Email Notifications

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Component Before After
Settings Navbar (Small Screen) Screenshot 2024-07-04 at 8 06 01 PM Screenshot 2024-07-04 at 8 05 55 PM
Settings Navbar (Normal Screen) Screenshot 2024-07-04 at 8 06 05 PM Screenshot 2024-07-04 at 8 05 50 PM
Email Notification Tab (Small Screen) Screenshot 2024-07-02 at 11.11.33 PM.png No change
Email Notification Tab Screenshot 2024-07-02 at 11.11.37 PM.png Screenshot 2024-07-04 at 8 16 57 PM

Tests

Email Settings reddot should show if not seen, and removed on click

  • Create a new Form
  • Go to Form Settings Page
  • Ensure that red dot is shown on Settings NavBar
  • Click on Settings Page NavBar
  • Ensure that red dot is not shown
  • Reload the page
  • Ensure that red dot is still not shown

This was referenced Jul 2, 2024
Merged
Merged
@KenLSM Graphite App
Copy link
Contributor Author

KenLSM commented Jul 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @KenLSM and the rest of your teammates on Graphite Graphite

@KenLSM KenLSM requested review from g-tejas and kevin9foong and removed request for g-tejas July 2, 2024 15:09
@linear Linear
Copy link

linear bot commented Jul 2, 2024

FRM-1758 Add Reddot to Email Settings in Form Settings Tab

@KenLSM KenLSM marked this pull request as ready for review July 2, 2024 15:13
@KenLSM KenLSM removed the request for review from kevin9foong July 3, 2024 02:24
g-tejas
g-tejas reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just have a small clarification

frontend/src/features/admin-form/settings/SettingsEmailsPage.tsx Show resolved Hide resolved
@KenLSM KenLSM force-pushed the feat/mrf-workflow-reddot branch from 30825a1 to f40a5f8 Compare July 3, 2024 14:05
@KenLSM KenLSM force-pushed the feat/storage-reddot branch from 6789d06 to 3cf7a4d Compare July 3, 2024 14:05
@KenLSM KenLSM force-pushed the feat/mrf-workflow-reddot branch from f40a5f8 to 9389b3e Compare July 3, 2024 14:07
@KenLSM KenLSM force-pushed the feat/storage-reddot branch from 3cf7a4d to 2cc20a2 Compare July 3, 2024 14:07
@KenLSM KenLSM force-pushed the feat/mrf-workflow-reddot branch from 9389b3e to 10be7ca Compare July 3, 2024 17:00
@KenLSM KenLSM force-pushed the feat/storage-reddot branch from 2cc20a2 to f8ecbaf Compare July 3, 2024 17:00
@KenLSM KenLSM force-pushed the feat/mrf-workflow-reddot branch from 10be7ca to 927194b Compare July 4, 2024 08:49
@KenLSM KenLSM force-pushed the feat/storage-reddot branch from f8ecbaf to 26f77af Compare July 4, 2024 08:49
@KenLSM KenLSM force-pushed the feat/mrf-workflow-reddot branch from 927194b to a044b80 Compare July 4, 2024 08:56
Base automatically changed from feat/mrf-workflow-reddot to develop July 4, 2024 08:58
@KenLSM KenLSM force-pushed the feat/storage-reddot branch from 26f77af to c05911a Compare July 4, 2024 10:53
g-tejas
g-tejas approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KenLSM KenLSM requested a review from g-tejas July 4, 2024 12:22
@KenLSM
Copy link
Contributor Author

KenLSM commented Jul 4, 2024

Hey @g-tejas requesting for a re-review, there was some changes in terms of the UI! Moved the reddot to Settings Navbar instead.

@KenLSM KenLSM closed this Jul 4, 2024
@KenLSM KenLSM reopened this Jul 4, 2024
@KenLSM KenLSM force-pushed the feat/storage-reddot branch from 32ce1f6 to d22b434 Compare July 4, 2024 12:28
g-tejas
g-tejas approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KenLSM KenLSM merged commit efe269a into develop Jul 5, 2024
16 of 18 checks passed
@KenLSM KenLSM deleted the feat/storage-reddot branch July 5, 2024 03:11
@KenLSM KenLSM mentioned this pull request Jul 7, 2024
Merged
35 tasks
g-tejas pushed a commit that referenced this pull request Jul 18, 2024
@KenLSM @g-tejas
feat: add reddot on email noti (#7463)
b506c88 
* feat: add reddot on email noti

* move reddot from email tab to settings navbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-tejas g-tejas g-tejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @g-tejas