chore: update travis to have multiple ci stages #742
Conversation
karrui
force-pushed
the
chore/travis-stages
branch
from
1326033 to
8148a58
Compare
|
Not really a speed up here, but that should change once we have 5 concurrent jobs lol |
|
OR... we can throw all of this away, and use the old script, but leave the coverage generation to |
karrui
force-pushed
the
chore/travis-stages
branch
from
ac012af to
19e2fa5
Compare
karrui
changed the title
karrui
force-pushed
the
chore/travis-stages
branch
from
19e2fa5 to
28d63ca
Compare
|
Decided to merge tests into a single stage, so we can still enjoy coverage only being called if the tests passes |
karrui
changed the title
karrui
force-pushed
the
chore/travis-stages
branch
from
354a4d1 to
18ee1a8
Compare
karrui
force-pushed
the
chore/travis-stages
branch
from
bfc89ee to
60bfb7d
Compare
|
That was a whirlwind of fun. I wonder if the time I spent on this will be returned via the dev time savings the team gets :P |
|
Might split them up into backend and frontend tests, then coalesce into e2e tests. The bottleneck is now the webpack building of front end, which takes 5 minutes for some reason. |
Allows for speed up of Jest tests See: https://itnext.io/how-to-make-your-sluggish-jest-v23-tests-go-faster-1d4f3388bcdd
| - stage: Tests | ||
| name: Javascript tests | ||
| workspaces: | ||
| use: build | ||
| script: | ||
| - travis_retry npm run test-backend-jasmine | ||
| - npm run test-frontend | ||
| - name: Typescript tests | ||
| workspaces: | ||
| use: build | ||
| script: | ||
| - travis_retry npm run test-backend-jest | ||
| after_success: | ||
| - cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js | ||
| - name: End-to-end tests | ||
| workspaces: | ||
| use: build | ||
| addons: | ||
| chrome: stable | ||
| script: | ||
| - npm run test-e2e-ci |
There was a problem hiding this comment.
these 3 jobs run in parallel, right?
There was a problem hiding this comment.
Yes, but it ends up being (slightly) slower (right now) since Travis is limited to 2 concurrent jobs. Probably what happened when we last looked at it. But with 5 jobs all can finally run at once and then should cut down a couple minutes
This PR uses build stages for Travis CI.
Benefits include not sending coverage when tests fail, since the
coveragestage is afterteststage, and will not be ran if tests fail. This allows us to also rerun builds instead of having to push empty commits to get coveralls working on build failuresshould also be faster once we have 5 concurrent jobs.