Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mention of data collation tool on landing and email settings results page #7390

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jun 13, 2024

Problem

We want to deprecate the data collation tool as part of the larger initiative. We are also looking at reducing the maintenance for data collation tool as we have a superior solution (storage mode-webhooks) to manage this.

Closes FRM-1739

Solution

Removed references to the data collation tool in the email responses tab and landing page.

Breaking Changes

  • No - this PR is backwards compatible

Copy link

linear bot commented Jun 13, 2024

Copy link
Contributor Author

KenLSM commented Jun 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @KenLSM and the rest of your teammates on Graphite Graphite

@KenLSM KenLSM changed the title remove mention of data collation tool on landing and email settings results page chore: remove mention of data collation tool on landing and email settings results page Jun 13, 2024
@KenLSM KenLSM requested review from kevin9foong and g-tejas June 13, 2024 06:13
@KenLSM KenLSM marked this pull request as ready for review June 13, 2024 06:13
Copy link
Contributor

@kevin9foong kevin9foong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

edit: i missed some unused imports and the existence of the OGP_FORMSG_COLLATE field still in links.ts when i wrote this

@kevin9foong kevin9foong self-requested a review June 13, 2024 14:09
Copy link
Contributor

@g-tejas g-tejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kevin9foong kevin9foong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the unused imports, it lgtm!

@KenLSM KenLSM requested a review from kevin9foong June 14, 2024 07:04
@KenLSM KenLSM merged commit 612420d into develop Jun 17, 2024
19 of 20 checks passed
@KenLSM KenLSM deleted the chore/frm-1739-remove-data-collation-tool-mention branch June 17, 2024 16:49
@KenLSM KenLSM mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants