-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-form): support nric masking #7388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
reviewed
Jun 13, 2024
KenLSM
reviewed
Jun 13, 2024
frontend/src/features/admin-form/settings/components/FormNricMaskingToggle.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jun 13, 2024
kevin9foong
force-pushed
the
feat/nric-masking
branch
5 times, most recently
from
June 16, 2024 13:30
9396389
to
c87e54a
Compare
The core functionality is complete
Remaining works are:
|
kevin9foong
force-pushed
the
feat/nric-masking
branch
3 times, most recently
from
June 21, 2024 08:42
bffe92b
to
aec8fcd
Compare
KenLSM
reviewed
Jun 21, 2024
.../features/admin-form/settings/components/AuthSettingsSection/AuthSettingsDescriptionText.tsx
Outdated
Show resolved
Hide resolved
...s/admin-form/settings/components/AuthSettingsSection/AuthSettingsDisabledExplanationText.tsx
Outdated
Show resolved
Hide resolved
...s/admin-form/settings/components/AuthSettingsSection/AuthSettingsDisabledExplanationText.tsx
Outdated
Show resolved
Hide resolved
...tend/src/features/admin-form/settings/components/AuthSettingsSection/AuthSettingsSection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/admin-form/settings/components/AuthSettingsSection/FormNricMaskToggle.tsx
Outdated
Show resolved
Hide resolved
...src/features/admin-form/settings/components/AuthSettingsSection/SingpassAuthOptionsRadio.tsx
Show resolved
Hide resolved
frontend/src/features/admin-form/settings/components/AuthSettingsSection/constants.ts
Show resolved
Hide resolved
frontend/src/features/admin-form/settings/components/FormIssueNotificationToggle.tsx
Outdated
Show resolved
Hide resolved
kevin9foong
force-pushed
the
feat/nric-masking
branch
from
June 24, 2024 14:03
3ad81e5
to
629a390
Compare
kevin9foong
force-pushed
the
feat/nric-masking
branch
from
June 24, 2024 14:39
fdd550b
to
5efe3b3
Compare
Ready for final review. pending design approval on chromatic |
kevin9foong
force-pushed
the
feat/nric-masking
branch
from
June 25, 2024 09:26
ebc0adb
to
b99448d
Compare
KenLSM
reviewed
Jun 25, 2024
KenLSM
reviewed
Jun 25, 2024
frontend/src/features/admin-form/settings/SettingsAuthPage.stories.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jun 25, 2024
...s/admin-form/settings/components/AuthSettingsSection/AuthSettingsDisabledExplanationText.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jun 25, 2024
...tend/src/features/admin-form/settings/components/AuthSettingsSection/AuthSettingsSection.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jun 25, 2024
...src/features/admin-form/settings/components/AuthSettingsSection/SingpassAuthOptionsRadio.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jun 25, 2024
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jun 25, 2024
src/app/modules/submission/encrypt-submission/encrypt-submission.types.ts
Show resolved
Hide resolved
kevin9foong
force-pushed
the
feat/nric-masking
branch
from
June 26, 2024 05:43
94c0ed2
to
a08fc76
Compare
…orrectly duplicated
KenLSM
reviewed
Jun 27, 2024
...features/admin-form/settings/components/AuthSettingsSection/AuthSettingsSectionContainer.tsx
Show resolved
Hide resolved
KenLSM
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @kevin9foong !
g-tejas
pushed a commit
that referenced
this pull request
Jul 18, 2024
* feat(admin-form): add frontend nric mask toggle to singpass auth settings * fix(admin-form): fix spacing and change units from px to rem * feat(admin-form): create isNricMaskingEnabled field in database when form is created * feat(admin-form): enable fetching and updating isNricMaskingEnabled field in backend routes * feat(admin-form): connect frontend component with server api routes * fix(admin-form): make code terser, remove unused params, fix nullish-coalesce operator usage * fix(admin-page): fix flickering bug * feat(duplicate-api): implement duplication of isNricMaskEnabled field * feat(public-form): prevent nric from reaching frontend if masked * feat(nric-mask): apply masking when submitting forms * feat(nric-mask): update frontend template to reflect masking toggle changes * fix(index.html): checkout to develop branch * fix: remove console.log * fix(toggle-component): replace nullish coalesce with ternary operator * chore(public-form-controller): remove masking when fetching public form at backend * fix: refactor email-submission-controller to mask at single location * fix: clean up nric-mask util function and unused imports * fix: update field with evaluated map value * feat: add nric masking to the frontend public form provider * feat: remove tooltip and labelComponentRight from Toggle to match design * feat: update settings auth page to reflect design master * feat: add err message * feat: change px to rem * feat: disable independently for nric masking and auth toggle * fix: change MyInfo to Myinfo in description message * fix: update form model test suite to expect new isNricMaskEnabled field * feat: add tests for nric mask util and masking for email submission * feat: add test for isNricMaskDisabled for email submission * feat: add tests for storage mode submission masking * fix: fix bug with submission not being able to save authType and defaulting to nil * feat: add stories for updated settings auth page * feat: update playwright test helper to support new auth setting flow * fix: fix review comments and run frontend lint fix * fix: fix based on chromatic review * fix: fix review comments * feat: add testing for getDuplicateParams to ensure that nricmask is correctly duplicated * refactor: extract skeleton component out to own file --------- Co-authored-by: Ken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Support Nric masking for e-voting.
Closes FRM-1736
Solution
Implement functionality and components as required.
Features:
Unit testing
src/app/modules/submission/encrypt-submission/__tests__/encrypt-submission.controller.spec.ts
&src/app/modules/submission/email-submission/__tests__/email-submission.controller.spec.ts
are written. these TC cover the nric mask enabled case and nric mask disabled case.Breaking Changes
Features:
Improvements:
Before & After Screenshots
Admin POV
radio options directly in settings auth page, old toast message
Respondent POV
Tests
Test email mode nric should be masked when nric mask toggle is on:
Test storage mode nric should be masked when nric mask toggle is on + myinfo fields are not masked despite nric masking enabled + settings auth options are correctly disabled/enabled based on form state: