-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conditionally render sex based on timezone #7376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
reviewed
Jun 10, 2024
...lderAndDesignDrawer/EditFieldDrawer/edit-fieldtype/EditMyInfoChildren/EditMyInfoChildren.tsx
Outdated
Show resolved
Hide resolved
KenLSM
requested changes
Jun 10, 2024
...lderAndDesignDrawer/EditFieldDrawer/edit-fieldtype/EditMyInfoChildren/EditMyInfoChildren.tsx
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Jun 10, 2024
KenLSM
requested changes
Jun 12, 2024
@KenLSM @kennethchangOPENGOV lemme know if any other changes needed! 🙏 thanks for reviewing |
KenLSM
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for looking into this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Partially Closes FRM-1727
Solution
Breaking Changes
Features:
Improvements:
Before & After Screenshots
BEFORE:
{shows gender}
AFTER:
CHILD/ CHILDREN
SELF
INFOBOX
Child
Self
Tests
Time-based simulation. Can try toggling dates
Deploy Notes
Probably should scrub this after the transition/ remove the time-checks post 1-jul/ when this is expected to go live
@KenLSM hope this implementation makes sense! 🙏