-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: release v6.118.0 #7300
Merged
Merged
build: release v6.118.0 #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [zod](https://github.com/colinhacks/zod) from 3.23.0 to 3.23.4. - [Release notes](https://github.com/colinhacks/zod/releases) - [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md) - [Commits](colinhacks/zod@v3.23.0...v3.23.4) --- updated-dependencies: - dependency-name: zod dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge release v6.117.0 into develop
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.16.0 to 4.17.0. - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v4.16.0...v4.17.0) --- updated-dependencies: - dependency-name: type-fest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add flag to allow global min override in form * allow fe variable fields to pass fe validators * allow respondent variable payment flow to respect global min override value * remove check min value check on respondent payment submission * fix: add missing default variable * test: add test cases for global limit
…reds (#7290) feat: add growthbook toggle to control adding twilio creds
update chromium version
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.17.0 to 4.18.0. - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v4.17.0...v4.18.0) --- updated-dependencies: - dependency-name: type-fest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: allow 0 cents
use different growthbook api
kathleenkhy
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-merge to
release-al2
as the #7293 merged with squash instead of merge with commit.New
#7294
#7290
#7291
#7280
#7282
#7284
#7266
Dependencies
#7287
#7283
Dev-Dependencies
Tests
feat(btn): phase 2 - add growthbook toggle to control adding twilio creds
#7290
Regression
Feature toggle is off, user should still see
will be
, and able to add twilio credentialswill be disabled from 30 April
New feature test
staging
env from growthbookwill be disabled from 30 April
Deploy Notes
Ensure that
adding-twilio-disabled
is added on growthbook (withvalue: True
, but not toggled onproduction
) . It should be disabled before April 30 or enabled if it is after April 30.New environment variables:
adding-twilio-disabled
: on growth book to control text message and button.feat(payments): add min global payment limit override
#7291
Approach for testing should be largely regressive in nature, as we do not have an account has this capability enabled from the 3rd party side (stripe).
Regression
Variable Payment - Admin
Variable Payment - Respondent
Enter an amount between S$0.50 and S$10.00.
Payment By Products - Admin
Payment By Products - Respondent
New feature test
Variable Payment - Admin
payments_field.global_min_amount_override
to be 10 (Int32
)Variable Payment - Respondent
Enter an amount between S$0.10 and S$10.00.