Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(btn): remove admin sms toggle check #7275

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 23, 2024

Problem

Missed out the whole backend changes for #7257.

Also took the chance to update backend tests.

Closes FRM-1716

Solution

Key logic changes were the removal of checks that will:

  1. Disable SMS (processAdminSmsCounts, disableVerifiedFieldsIfRequired)
  2. Block OTP Verification toggle on updates from FormFE (shouldUpdateFormField)

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression

Admins can update twilio credentials

  • Create a new storage form
  • Go to Form Twilio Settings page
  • Enter ACC, SKK, SKK, MGG for the respective fields
  • Ensure that clicking on save credentials isn't blocked

Admins can update OTP fields

  • Ensure that clicking on "Remove and re-enter credentials" isn't blocked

Respondent OTP verification still works

  • Add Mobile field
  • Enable OTP verification
  • Open up the admin form
  • Ensure that verify sends an SMS to you

New feature test

  • Update on SSM SMS_VERIFICATION_LIMIT to 10
  • Send 10 SMS
  • Ensure that the 11th SMS is still received by respondent
  • Ensure that admin can still toggle on and off OTP verification field

Copy link

linear bot commented Apr 23, 2024

@KenLSM KenLSM force-pushed the fix/btn-admin-sms-toggle branch from 88f3673 to dad35ee Compare April 23, 2024 07:36
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KenLSM KenLSM merged commit 0a03210 into develop Apr 23, 2024
20 checks passed
@KenLSM KenLSM deleted the fix/btn-admin-sms-toggle branch April 23, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants