Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update chromium to latest published version #7252

Merged
merged 2 commits into from
Apr 8, 2024
Merged

chore: update chromium to latest published version #7252

merged 2 commits into from
Apr 8, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 8, 2024 •
edited
Loading

Problem

Fixes build issue where a specific outdated chromium is not found.

Solution

Updates corresponding chromium version, and puppeteer-core

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression

  • Create a payment form
  • Submit the payment
  • Ensure that the payment receipt is generated without errors

@KenLSM KenLSM requested a review from kathleenkhy April 8, 2024 05:19
kathleenkhy
kathleenkhy approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@kathleenkhy kathleenkhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@KenLSM KenLSM merged commit 727a2ac into develop Apr 8, 2024
36 checks passed
@KenLSM KenLSM deleted the chore/update-chromium-puppeteer-core branch April 8, 2024 05:49
@KenLSM KenLSM mentioned this pull request Apr 8, 2024
Merged
9 tasks
@KenLSM KenLSM mentioned this pull request Apr 22, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathleenkhy kathleenkhy kathleenkhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @kathleenkhy