Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate rating validator to ts #724

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Nov 24, 2020

Problem

Part of #7

Solution

Improvements

  • Migrates rating validation to Typescript

Tests

  • Create two rating fields. Hide one of them behind logic.
  • Check that validation on both visible and hidden rating fields work by submitting programatically
  • Rating is accepted if it is an integer between 1 and "steps", rejected otherwise
  • Rating must not have trailing zero

@tshuli tshuli requested review from mantariksh and karrui November 24, 2020 13:27
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tshuli tshuli force-pushed the refactor/rating-validator branch from 521b37f to 88327a2 Compare November 25, 2020 03:10
@tshuli tshuli merged commit ea7c6e8 into develop Nov 25, 2020
@karrui karrui mentioned this pull request Dec 1, 2020
@liangyuanruo liangyuanruo deleted the refactor/rating-validator branch January 26, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants