Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate radio button validator to ts #723

Merged
merged 3 commits into from
Nov 25, 2020
Merged

refactor: migrate radio button validator to ts #723

merged 3 commits into from
Nov 25, 2020

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Nov 24, 2020

Problem

Part of #7

Solution

Improvements

  • Migrates Radio Button validation to Typescript
  • Updates tests to include isVisible

Tests

  • Create two radio button fields. Hide one of them behind logic.
  • Check that validation on both visible and hidden radio button fields work, when submitting programatically
  • Answer is accepted if it is one of the options or "other" if enabled
  • Answer is rejected otherwise

@tshuli tshuli changed the title Refactor/radio button validator refactor: migrate radio button validator to ts Nov 24, 2020
@tshuli tshuli requested review from karrui and mantariksh November 24, 2020 13:28
karrui
karrui approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tshuli tshuli merged commit 2aaf4db into develop Nov 25, 2020
@liangyuanruo liangyuanruo deleted the refactor/radio-button-validator branch November 25, 2020 03:34
@tshuli tshuli mentioned this pull request Nov 25, 2020
Closed
@karrui karrui mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

@mantariksh mantariksh Awaiting requested review from mantariksh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshuli @karrui