feat: migrate get encrypt metadata endpoint controller to TypeScript #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
approved these changes
Nov 25, 2020
| ): ResultAsync<SubmissionMetadata | null, DatabaseError> => { | ||
| // Early return, do not even retrieve from database. | ||
| if (!mongoose.Types.ObjectId.isValid(submissionId)) { | ||
| return okAsync(null) |
There was a problem hiding this comment.
do we actually want to return 200 with an empty list if the submission ID in the query parameter is invalid? isn't that more of a 400?
There was a problem hiding this comment.
this is due to frontend sending possible invalid submissionIds due to search, and if we return 400 an error is shown to the user resulting in confusion.
returning nothing means no result found, but it's still a valid search term i guess.
We can change it if you want, just not in this PR.
Related issue opened for the debounce thingy: #603
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building upon #601, this PR migrates the rest of the controller into Typescript.
Solution
Features:
EncryptSubSvc#getSubmissionMetadataservice fn to use model static methodEncryptSubSvc#getSubmissionMetadataListservice fn to use model static methodEncryptSubCtl#handleGetMetadatahandler fn for route endpointImprovements:
query.pageis now optional iffquery.submissionIdexists, since singular submission metadata search does not require the page parameter.Tests
Add tests for all new methods.
Note that route integration tests are not done in this PR, and will be done when route also gets refactored.