fix(markdown): handle newlines after indentation groups #6941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Given
Title 2 will be rendered under the same indentation as
item 2
as it did not break out of the<li>
group.Replacing
\n
with an empty space prevents markdown from detecting\n\n
that signifies a break from the list item.The previous PR which tackled this issue #6917 was reverted as older versions of Safari could not handle Lookbehind in regular expressions
Solution
Replace
\n
that comes after a list item with\n
Breaking Changes
Before & After Screenshots
BEFORE:
AFTER:
Tests
title 2
should not be indentedtitle 2
should not be indented