Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add learn more link #6897

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: add learn more link #6897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/features/rollout-announcement/components/AnnouncementsFeatureList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { GUIDE_PAYMENTS_ENTRY } from '~constants/links'
import { GUIDE_PAYMENTS_ENTRY, GUIDE_SPCP_ESRVCID } from '~constants/links'

import { FeatureUpdateImage } from '~features/whats-new/FeatureUpdateList'

Expand All @@ -20,6 +20,7 @@ export const NEW_FEATURES: NewFeature[] = [
title: 'Myinfo fields for Storage mode forms',
description:
'Get verified data from respondents by adding Myinfo fields to your Storage mode form. To enable Myinfo fields, select one of our Myinfo-enabled authentication options in your form’s settings.',
learnMoreLink: GUIDE_SPCP_ESRVCID,
image: {
url: myInfoStorageMode,
alt: 'Myinfo fields for Storage mode forms',
Expand Down
5 changes: 2 additions & 3 deletions frontend/src/features/whats-new/FeatureUpdateList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import dedent from 'dedent'
import { JsonObject, RequireExactlyOne } from 'type-fest'

import { GUIDE_PAYMENTS_ENTRY } from '~constants/links'
import { GUIDE_PAYMENTS_ENTRY, GUIDE_SPCP_ESRVCID } from '~constants/links'

import Animation2 from './assets/2-payments.json'
import Animation3 from './assets/3-search-and-filter.json'
Expand Down Expand Up @@ -38,8 +38,7 @@ export const FEATURE_UPDATE_LIST: FeatureUpdateList = {
{
title: 'Myinfo fields for Storage mode forms',
date: new Date('16 Nov 2023 GMT+8'),
description:
'Get verified data from respondents by adding Myinfo fields to your Storage mode form. To enable Myinfo fields, select one of our Myinfo-enabled authentication options in your form’s settings.',
description: `Get verified data from respondents by adding Myinfo fields to your Storage mode form. To enable Myinfo fields, select one of our Myinfo-enabled authentication options in your form’s settings. [Learn more](${GUIDE_SPCP_ESRVCID})`,
image: {
url: MyInfoStorageMode,
alt: 'Myinfo fields for Storage mode forms',
Expand Down
Loading