Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: announcement modal and what's new for myinfo storage-mode #6892

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Nov 15, 2023

Problem

Part of FRM-1430

Solution

Add a new announcement to the What's New sidebar and Announcement Modal for the release of MyInfo storage mode

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

AFTER:

image

image

Copy link

linear bot commented Nov 15, 2023

FRM-1430 MyInfo storage mode

Description

Implement MyInfo on storage mode forms

Additional context

RFC

Todo

  • Check if there's a limit to the number of myinfo fields allowed on storage mode (change copy?)
  • Announcement to admins?

Blockers

@wanlingt wanlingt requested a review from KenLSM November 15, 2023 04:08
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wanlingt wanlingt merged commit 432ebdf into develop Nov 15, 2023
21 of 23 checks passed
@wanlingt wanlingt deleted the feat/myinfo-announcement branch November 15, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants