Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): webkit-related stylings #6875

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Nov 7, 2023

Problem

On mobile phones and safari, the text input for DatePicker

  • affects only <DatePicker />, other <Input />-related fields are not affected
  • affects specifically when component is disabled

Screenshot 2023-11-07 at 5 18 56 PM

  • text is set to gray but appears to be whitish-grey on chrome mobile, and safari browsers

Closes FRM-1473

Solution

  • Took reference from design-system and extracted aria fields and moved them down into the child components.
  • Fixed missing borderRightRadius on <CalendarButton />

Ideally, we should migrate to use design-system so that we don't have to patch issues like this.

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Location/Modifier Before After
Active uat_active local_active
Filled uat_filled local_filled
Error uat_error local_error
Disabled uat_disabled local_disabled
Admin uat-admin local-admin
Admin Active uat-admin_active local-admin_active
Admin Hover uat-admin_hover local-admin_hover
Admin Error uat-admin_error local-admin_error

Tests

Regression Tests

  • Ensure that DatePicker fields cannot be interacted when field is disabled
  • Ensure that DatePicker fields cannot be selected with Tab when field is disabled
  • Ensure that DatePicker input field is visible when viewed from Safari browser when field is disabled

@KenLSM KenLSM changed the title fix: prevent unused outer aria from affecting webkit-related styles fix(datepicker): webkit-related stylings Nov 7, 2023
Copy link

linear bot commented Nov 7, 2023

@KenLSM KenLSM requested a review from wanlingt November 7, 2023 14:19
@KenLSM KenLSM marked this pull request as ready for review November 7, 2023 14:19
Copy link
Contributor

@wanlingt wanlingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for fixing this!!

@KenLSM KenLSM enabled auto-merge (squash) November 8, 2023 10:53
@KenLSM KenLSM merged commit 9cf4594 into develop Nov 8, 2023
15 checks passed
@KenLSM KenLSM deleted the fix/safari-disable-input-color branch November 8, 2023 11:12
@wanlingt wanlingt mentioned this pull request Nov 9, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants