Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add case for SGID MyInfo when field value is missing #6874

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Nov 7, 2023

Problem

False positives (field values that were not missing from the constants lists) were being logged because of an erroneous SGID check. As a result, a monitor was being falsely triggered

Solution

Add separate conditionals for Singpass and SGID MyInfo values

Breaking Changes

  • No - this PR is backwards compatible

Tests

Singpass MyInfo

  • Submit a Singpass MyInfo form that contains the MyInfo nationality field
  • Check that the field is not logged in error logs (search for meta.action like 'prefillAndSaveMyInfoFields')

SGID MyInfo

  • Submit a SGID MyInfo form that contains the MyInfo nationality field
  • Check that the field is not logged in error logs (search for meta.action like 'prefillAndSaveMyInfoFields')

@wanlingt wanlingt requested a review from KenLSM November 7, 2023 08:37
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanlingt wanlingt enabled auto-merge (squash) November 7, 2023 08:44
@wanlingt wanlingt merged commit 28cfa54 into develop Nov 7, 2023
@wanlingt wanlingt deleted the fix/missing-myinfo-value branch November 7, 2023 09:12
@tshuli tshuli mentioned this pull request Nov 8, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants