-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: myinfo for storage-mode #6870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRM-1430 MyInfo storage mode
Description Implement MyInfo on storage mode forms Additional context Todo
Blockers |
b2b8ca5
to
c876fc9
Compare
2f4107c
to
fdaa622
Compare
fdaa622
to
afcef86
Compare
KenLSM
reviewed
Nov 14, 2023
...ures/workspace/components/CreateFormModal/CreateFormModalContent/CreateFormDetailsScreen.tsx
Show resolved
Hide resolved
KenLSM
reviewed
Nov 14, 2023
frontend/src/features/admin-form/settings/components/AuthSettingsSection/constants.ts
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Nov 14, 2023
KenLSM
reviewed
Nov 14, 2023
KenLSM
reviewed
Nov 14, 2023
KenLSM
reviewed
Nov 14, 2023
KenLSM
reviewed
Nov 14, 2023
src/app/modules/submission/encrypt-submission/encrypt-submission.middleware.ts
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Nov 14, 2023
src/app/modules/submission/encrypt-submission/encrypt-submission.utils.ts
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Nov 14, 2023
src/app/modules/submission/encrypt-submission/encrypt-submission.utils.ts
Outdated
Show resolved
Hide resolved
KenLSM
reviewed
Nov 14, 2023
KenLSM
reviewed
Nov 14, 2023
…to shared submission.utils
KenLSM
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Happy to see that we're removing lots of code too!
This was referenced Nov 15, 2023
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to make MyInfo fields available on storage-mode forms now that we've done the encryption boundary shift, and are able to validate form responses
Closes FRM-1430
Solution
Frontend
Backend
MyInfo
andSGID_MyInfo
to the form modelencrypt-submission.middleware
. This is done in thevalidateStorageSubmission
step, before the form responses are encrypted. We also format the question name by prefixing it with [MyInfo] if it is verified in this step. Each subfield in a Child Record is listed as a new field in the form response.encrypt-submission.controller
Other fixes
connect.sid
toformsg.connect.sid
in local dev.connect-sid
value which would log the admin out of their account. This was causing the new MyInfo playwright test to fail.formsg.connect.sid
across all environments.Breaking Changes
Before & After Screenshots
Tests
Singpass MyInfo
2a. Submit storage mode form with Singpass MyInfo fields
2b. Duplicate email mode form as storage mode using the duplicate button
2c. Duplicate email mode form as storage mode using the use-template link
SGID MyInfo
3a. Submit storage mode form with SGID MyInfo fields
3b. Duplicate email mode form as storage mode
3c. Duplicate email mode form as storage mode using the use-template link