chore: remove eb shift frontend feature flags

[tshuli]

Problem

Works towards FRM-1232 and FRM-1413

• This PR removes the frontend feature flags for (i) encryption boundary shift and (ii) virus scanner. Henceforth, all frontend traffic will be routed through the new storage mode endpoint and virus scanner.
• This is in preparation for myinfo storage mode feature.

Tests

• Create storage mode form. Open in public form view.
• Submission with attachment works
• Attachment is uploaded to s3
• Malicious attachment is blocked
  secure.eicar.org_eicar.com.txt

[wanlingt]

generally lgtm!

I also searched FRM-1232 and FRM-1413 in the codebase to check for other TODOs in the frontend. In createSubmission.ts, we can remove filterSendableStorageModeResponses and the function that it's used in (createEncryptedSubmissionData). I realised from there that we're still using the old /encrypt endpoint for preview mode - it's non-blocking for this PR (only when we remove the backend endpoints) but just to note for next time.

also a nit: should we remove "Clear" from the function names - e.g. submitStorageModeClearFormWithVirusScanningWithFetch? I don't think it adds much since now there's no distinction between the modes to submit a storage mode form

[linear]

FRM-1413 Remove virus scanning feature flag

Description

Remove virus scanning feature flag once virus scanner integration has been completely rolled out.

Search for TODO (FRM-1413) in codebase

FRM-1232 Remove old storage submission endpoint & encryption boundary shift feature flag

Description

Remove old storage submission endpoint to cleanup codebase.

[tshuli]

thanks @wanlingt ! will go thru the comments :)

There is an existing ticket to implement the encryption boundary shift for preview mode, but as you said, non-blocking for now:
https://linear.app/ogp/issue/FRM-1506/encryption-boundary-shift-for-storage-mode-form-submissions-previews

[wanlingt]

thanks @wanlingt ! will go thru the comments :)

There is an existing ticket to implement the encryption boundary shift for preview mode, but as you said, non-blocking for now: https://linear.app/ogp/issue/FRM-1506/encryption-boundary-shift-for-storage-mode-form-submissions-previews

oh nice thanks @tshuli ! Just added it to the Shift Encryption Boundary project on linear