Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspaces): remove form from collab workspace #6843

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

foochifa
Copy link
Contributor

Problem

Closes FRM-1478

Solution

Iterate thru the list of permissions, retrieve the user from the email, then remove the formId from all the workspaces under the user.

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Tests

  • As a collaborator of the form, move the form into a workspace
  • As the owner of the same form, delete the form
  • The form should be removed from the collaborator's workspace, check that the total form number tally is correct.

@linear
Copy link

linear bot commented Oct 26, 2023

FRM-1478 Remove formId from all collaborators folders upon deletion

To replicate bug:

Give collaborator a form, collaborator add form to a folder
As owner, delete the form, the folder has a dangling formId (i.e. number of forms) on the dashboard

@foochifa foochifa requested review from tshuli and KenLSM October 26, 2023 03:34
@foochifa foochifa changed the title fix: remove form from collab workspace fix(workspaces): remove form from collab workspace Oct 26, 2023
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanlingt wanlingt merged commit 9de3626 into develop Oct 30, 2023
@wanlingt wanlingt deleted the fix/remove-form-from-collab-workspace branch October 30, 2023 08:01
@wanlingt wanlingt mentioned this pull request Oct 30, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants