Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobileno is always editable #6841

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: mobileno is always editable #6841

merged 1 commit into from
Oct 26, 2023

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Oct 25, 2023 •
edited
Loading

Problem

The Singpass data catalog states that the mobile number field should always be editable. However, it's currently uneditable for SGID MyInfo.

Solution

Move MobileNoWithCountryCode to the editable case

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

BEFORE:

image

AFTER:

image

Tests

  • As an admin, create a form with the auth method "Singpass App-only with MyInfo" and add the "Mobile Number" MyInfo field
  • Open the form and log in using a profile that has a mobile number, using the SGID Chrome extension (first profile Singaporean)
  • The mobile number field should not be disabled
  • Submit the form, the mobile number field should be reflected in the response

@wanlingt wanlingt temporarily deployed to staging October 26, 2023 03:20 — with GitHub Actions Inactive
tshuli
tshuli approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wanlingt wanlingt enabled auto-merge (squash) October 26, 2023 03:40
@wanlingt wanlingt merged commit f6d6ddb into develop Oct 26, 2023
42 checks passed
@wanlingt wanlingt deleted the fix/sgidmyinfo-mobile branch October 26, 2023 03:43
@wanlingt wanlingt mentioned this pull request Oct 26, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshuli tshuli tshuli approved these changes

@foochifa foochifa Awaiting requested review from foochifa

@KenLSM KenLSM Awaiting requested review from KenLSM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanlingt @tshuli