fix: missing errors in error mapper #6764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The errors
AttachmentTooLargeError
andInvalidFileExtensionError
were missing from the error mapper used for storage mode submissions. This caused them to throw 500 unknown route errors. This is an example trace of presenting this issue.Solution
Breaking Changes
Bug Fixes:
AttachmentTooLargeError
andInvalidFileExtensionError
errors added to error mappers to be treated like other form submission errors where validation fails. There should be a 400 status code returned and an error message asking them to try again. These 2 were the missing error mappings identified from possible errors fromsrc/app/modules/submission/encrypt-submission/encrypt-submission.middleware.ts
>validateStorageSubmission
.Tests
-I
flag to the cURL request.