Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove divider in payments input panel #6586

Merged
merged 1 commit into from
Aug 1, 2023
Merged

feat: remove divider in payments input panel #6586

merged 1 commit into from
Aug 1, 2023

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Aug 1, 2023 •
edited
Loading

Content

This PR removes the divider between the Product's name and description in the payments inputs panel

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

BEFORE:

image

AFTER:

image (2)

KenLSM
KenLSM approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although probably would have some merge conflicts with payments by products 😆

@wanlingt wanlingt merged commit c24ef55 into develop Aug 1, 2023
@wanlingt wanlingt deleted the fix/payments-input-panel branch August 1, 2023 09:07
LeonardYam pushed a commit to LeonardYam/FormSG that referenced this pull request Aug 3, 2023
@wanlingt @LeonardYam
feat: remove divider in payments input panel (opengovsg#6586)
cd81e2d
@foochifa foochifa mentioned this pull request Aug 7, 2023
Merged
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanlingt @KenLSM