feat: check new owner email domain before transferring form ownership #6500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jia1, are you still working on this? I am looking to clean up abandoned PRs and wondering if there's any interest to continue on this. Otherwise, will close the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
(Don't know if this issue has been worked on, but I've been working on a related feature (#34) which might have expected this issue to be part of the scope at first.)
Problem description: Unlike
updateFormCollaborators, intransferFormOwnership, the new owner's email domain is not checked against theAgencyModel. We should check.Might resolve #5971
Solution
Copy the email domain check from
updateFormCollaboratorsbut do it at the start oftransferFormOwnership.Breaking Changes
Improvements:
.split('@').pop()with the same intent into a utility functiongetEmailDomainFromEmail.Tests
TBC