Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade spcp-auth-client to TypeScript version #649

Merged
merged 1 commit into from
Nov 17, 2020
Merged

feat: upgrade spcp-auth-client to TypeScript version #649

merged 1 commit into from
Nov 17, 2020

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Nov 17, 2020 •
edited
Loading

This PR upgrades @opengovsg/spcp-auth-client to the latest, typed version.

Tests

  • Create an email mode form. Change the auth type to SingPass. Activate the form and submit it.
  • Create an email mode form. Change the auth type to CorpPass. Activate the form and submit it.
  • Create a storage mode form. Change the auth type to SingPass. Activate the form and submit it.
  • Create a storage mode form. Change the auth type to CorpPass. Activate the form and submit it.

@mantariksh mantariksh requested review from tshuli and karrui and removed request for tshuli November 17, 2020 03:19
@mantariksh mantariksh merged commit f25fd42 into develop Nov 17, 2020
@karrui karrui mentioned this pull request Nov 17, 2020
Merged
@karrui karrui deleted the feat/upgrade-spcp branch November 18, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

@tshuli tshuli Awaiting requested review from tshuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mantariksh @karrui