Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge release 4.45.1 hotfix back to develop #648

Merged
merged 2 commits into from
Nov 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [v4.45.1](https://github.com/opengovsg/FormSG/compare/v4.45.0...v4.45.1)

- fix: update email list correctly when deleting emails [`5776c2d`](https://github.com/opengovsg/FormSG/commit/5776c2d3d079e2876aacb17c41c398031a8ff939)

#### [v4.45.0](https://github.com/opengovsg/FormSG/compare/v4.44.0...v4.45.0)

> 10 November 2020

- feat: update landing page footer [`#584`](https://github.com/opengovsg/FormSG/pull/584)
- chore: set datepicker default view to minimum date [`#574`](https://github.com/opengovsg/FormSG/pull/574)
- fix(deps): bump @sentry/integrations from 5.25.0 to 5.27.3 [`#600`](https://github.com/opengovsg/FormSG/pull/600)
Expand All @@ -30,6 +36,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- chore(deps-dev): bump jest from 26.5.3 to 26.6.2 [`#570`](https://github.com/opengovsg/FormSG/pull/570)
- refactor: convert MyInfo hash update to static domain method [`#562`](https://github.com/opengovsg/FormSG/pull/562)
- chore: shift webhook field to bottom of settings page, update copy [`#553`](https://github.com/opengovsg/FormSG/pull/553)
- chore: bump version to 4.45.0 [`c8d3463`](https://github.com/opengovsg/FormSG/commit/c8d346350949050c2eb87d5564d9e3ba623a5956)

#### [v4.44.0](https://github.com/opengovsg/FormSG/compare/v4.43.2...v4.44.0)

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "FormSG",
"description": "Form Manager for Government",
"version": "4.45.0",
"version": "4.45.1",
"homepage": "https://form.gov.sg",
"authors": [
"FormSG <[email protected]>"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function settingsFormDirective(
const emailsFieldIncorrectlyAdded =
updatedSettings.emails &&
!Array.isArray(tempForm.emails) &&
myform.emails[0] === tempForm.emails
myform.emails.join(',') === tempForm.emails
if (emailsFieldIncorrectlyAdded) delete updatedSettings.emails

return updatedSettings
Expand Down