Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused angular deps #6438

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jun 8, 2023

Problem

A continuation of #6344.
We are currently still having several dependencies that were used previously by angular. These dependencies would 1) slow down our build (and by extension deployment), as well as dependabot raising distractive PRs to bump these unused dependencies.

Solution

Breaking Changes

  • No - this PR is backwards compatible

Tests

React bundling should be unaffected

  • can view FormSG React homepage

Deploy Notes

Removed dev dependencies:

  • copy-webpack-plugin : used in angular to copy static assets for the file server to serve
  • google-fonts-plugin : used in angular only
  • mini-css-extract-plugin : used in angular's webpack to chunk css, from our angular code, by page
  • optimize-css-assets-webpack-plugin : used in angular's webpack to run various css optimization
  • terser-webpack-plugin : used in angular's webpack to
  • webpack-merge : used in angular's webpack

@KenLSM KenLSM requested a review from justynoh June 8, 2023 06:18
@KenLSM
Copy link
Contributor Author

KenLSM commented Jun 8, 2023

Should also naturally make PR #6371, and #6371 from dependabot irrelevant.

@KenLSM KenLSM enabled auto-merge (squash) June 8, 2023 06:21
@KenLSM KenLSM merged commit 6eb859e into develop Jun 8, 2023
@KenLSM KenLSM deleted the chore/remove-unused-webpack-deps branch June 8, 2023 06:52
KenLSM added a commit that referenced this pull request Jun 8, 2023
@LinHuiqing LinHuiqing mentioned this pull request Jun 12, 2023
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants