feat: payment banners on landing and login pages #6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use link constants for payments copies
- fix h5 and h6 typography styles
- note: center on the y axis
|
@staceytan1998 seems like chromatic still isn't rendering it properly, could you check the copy on staging-alt2.form.gov.sg instead? |
LinHuiqing
changed the title
|
for posterity, banners do not render properly on chromatic and have been (slack) approved by designer @staceytan1998 after checking the banners on staging-alt2.form.gov.sg. |
KenLSM
reviewed
Jun 8, 2023
KenLSM
reviewed
Jun 8, 2023
KenLSM
approved these changes
Jun 8, 2023
KenLSM
pushed a commit
that referenced
this pull request
Jun 8, 2023
* feat: login page banner * ref: pass links into FeatureBanner - use link constants for payments copies * fix: contrast login banners from background * fix: hover colour based on figma * chore: remove unnecessary variant def * feat: add h5 and h6 textStyles * feat: landing page banner * fix: banner spacing - fix h5 and h6 typography styles * fix: justify text for login banner - note: center on the y axis * fix: only set banner color when provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
More marketing efforts for our payments feature!
Closes FRM-960, closes FRM-961
Solution
Breaking Changes
Features:
Improvements:
Bug Fixes:
Before & After Screenshots
BEFORE:
Landing Page:
Login Page:
AFTER:
Landing Page:
Desktop:
Mobile:
Login Page:
Desktop:
Mobile:
Tests
Check that new banners work:
Check that the refactor that takes out the links as constants works with the existing payments copy things: