feat: MyInfo over sgID backend #6337
Conversation
|
Thanks for the extremely thorough and insightful review Shu Li. I tried to address it. Now, submitting SGID-MyInfo forms don't log out an already logged in SGID-Auth form :). |
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Show resolved
Hide resolved
|
Couple of minor comments, but lgtm otherwise! |
|
@timotheeg would be good if you could have another look through before this is merged in |
There was a problem hiding this comment.
Looking good KenJin! 🥳
I only have some super very comments, so I think it's pretty much ready to go! 💪
And I will try to do a second pass tomorrow morning to make sure I understand correctly all the typing magic with the generics (I'm not very good at reading generics 😅)
| meta, | ||
| error: jwtResult.error, | ||
| }) | ||
| res.cookie('isLoginError', true) |
There was a problem hiding this comment.
/notYourPR-DontChangeAnything-JustNoting: putting an error flag in a client cookie feels a bit dirty 😅 ... Ideally, we should have sessions for respondent, and the error details should be set and retrieved from that. The client should not be able to drive error handling behaviour from cookies
There was a problem hiding this comment.
Yeah unfortunately that's how the existing code does this :(.
|
Thanks for the thorough review Tim! |
Problem
Retrieving MyInfo data over sgID is currently not supported.
Closes #6323
Solution
Breaking Changes
Features:
Before & After Screenshots
(We want no difference, since it's disabled on the frontend).
BEFORE:
AFTER:
Tests
I've added tests to the sgID adapter to make sure it works. It should automatically be run as part of the existing test suite.