Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.47.0 #6279

Merged
merged 12 commits into from
May 8, 2023
Merged

build: release v6.47.0 #6279

merged 12 commits into from
May 8, 2023

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented May 8, 2023 •
edited by foochifa
Loading

New

  • feat: add frontend datadog logging to CSV responses download #6266
  • fix: migrate to withTransaction for retries #6263
  • feat: remove web flag from release script #6269
  • feat: add payment item details to payment page #6235
  • fix: add env parameter to Stripe metadata, check value before processing events #6234
  • fix: switch captcha to download from globally accessible domain #6243
  • fix: check payments channel before updating payments field #6258
  • feat: payment preview banner #6230
  • build: merge release v6.46.0 to develop #6256
  • chore: bump version to v6.47.0 #6279

Dependencies

  • fix(deps): bump libphonenumber-js from 1.10.28 to 1.10.30 in /shared #6278
  • fix(deps): bump type-fest from 3.9.0 to 3.10.0 in /shared #6271

Dev-Dependencies

Tests

feat: add frontend datadog logging to CSV responses download #6266

@foochifa

  • On a storage mode results page, download 'CSV only'. Check if logs show up in Datadog (search for service:formsg env:staging @meta.action:downloadEncryptedReponses).
  • Repeat the same for 'CSV with attachments'

feat: add payment item details to payment page #6235

@foochifa

  • On a payments form, verify your email and click Proceed to Pay. The payment item details (name of product, amount payable) should be visible above the credit card payment block.

fix: check payments channel before updating payments field #6258

@wanlingt

To ensure correct behaviour after fix

  • create a storage mode form, connect payments
  • go to build and design tab, enable payment fields
  • ensure that the field is enabled by previewing the form
  • go back to build and design tab, ensure this tab is remains open with the payment enabled toggle on
  • on another window, go to the same form and disconnect payment
  • return to the build and design tab and update payments with payment enabled toggled on
  • it should fail and return 400

To check for regression

  • after the steps above, go back to settings and connect payment
  • you should be able to enable payment fields now

feat: payment preview banner #6230

To check that the feature has been implemented correctly

  • go to a payment form. Click preview. Ensure that the banner is shown as per our design figma

To ensure no regression problems
Payment modals

  • make a payment on a payment form. Check that payment modal is displayed. Complete payment
  • make a duplicate payment on a payment form. check that duplicate payment modal is displayed. The link works to link back to previous payment page. Make payment intent but do not complete payment
  • go back to form. Make sure payment resume modal is displayed and works correctly (restore previous + start over)

Non-payment

  • go to a non-payment email form. make a submission
  • go to a non-payment storage form. make a submission

Use-template (lets bring templates for payment form up for discussion next time)

  • create a template on a non-payment form, no payment preview banner etc should be shown.

wanlingt and others added 11 commits May 3, 2023 18:20
@wanlingt
Merge pull request #6256 from opengovsg/release-al2
dacc3a6 
build: merge release v6.46.0 to develop
@foochifa
feat: payment preview banner (#6230)
b6b870a 
* feat: add isPaymentEnabled to public form context

* feat: usePublicFormContext to check for payment

* feat: create banner for payment preview
@foochifa
fix: check payments channel before updating payments field (#6258)
e8e4a63 
* fix: add payment channel not found error

* fix: add payment channel check before updating payments field

* fix: use payment channel for unconnected comparison

* fix: change status code and error message

* fix: incorrect boolean and import path

* chore: change to inline conditional without negation
@KenLSM
fix: switch captcha to download from globally accessible domain (#6243)
31f5a9c 
* switch captcha to download from globally accessible domain

* fix recaptch url missing www. subdomain
@justynoh
fix: add env parameter to Stripe metadata, check value before process…
178942c 
…ing events (#6234)

* fix: add env parameter to Stripe metadata, check value before processing events

* fix: better error codes for webhook handler returns

* fix: remove unneeded Joi validation on previous payment endpoint

* chore: remove unused variable

* chore: clarify comment

* test: add SSM_ENV_SITE_NAME to test env

* test: update tests
@wanlingt
feat: add payment item details to payment page (#6235)
917fe25 
* feat: extract payment item details into PaymentItemDetailsBlock

* feat: add PaymentItemDetailsBlock to PaymentBlock

* ref: use shared component PaymentItemDetailsBlock

* fix: remove mb from PaymentItemDetailsBlock
@dependabot
fix(deps): bump type-fest from 3.9.0 to 3.10.0 in /shared (#6271)
9c76039 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 3.9.0 to 3.10.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v3.9.0...v3.10.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@wanlingt
feat: remove web flag from release script (#6269)
6474d83 
feat: remove web flag
@justynoh
fix: migrate to withTransaction for retries (#6263)
4d49022 
* fix: migrate to withTransaction for retries

* fix: update post-submission actions to only occur after transaction is committed

* chore: add errors to mapRouteError

* chore: clean up comments
@wanlingt
feat: add frontend datadog logging to CSV responses download (#6266)
e08f146 
* feat: add frontend datadog logging to useDecryptionWorkers

* fix: correct typo in google analytics trackDownloadResponseFailure

* fix: add downloadAttachments property to logs

* fix: add missing dependency
@dependabot
fix(deps): bump libphonenumber-js from 1.10.28 to 1.10.30 in /shared (#…
29da992 
…6278)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.28 to 1.10.30.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.28...v1.10.30)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@wanlingt wanlingt temporarily deployed to staging-al2 May 8, 2023 01:38 — with GitHub Actions Inactive
@wanlingt wanlingt force-pushed the release_v6.47.0 branch from 29b56cc to 002b8b6 Compare May 8, 2023 02:04
@wanlingt wanlingt temporarily deployed to staging-al2 May 8, 2023 02:10 — with GitHub Actions Inactive
@foochifa
Copy link
Contributor

foochifa commented May 8, 2023 •
edited
Loading

Don't think this is a blocking issue. But once again I think we probably should disable payment modification when form is open.

for #6235,

  • if you press 'proceed to pay', and on the payment page,
  • as an admin, modify the payment field details (e.g. amount).
  • refresh the payment page from above, you will see a new amount
  • pay (realise you are charged the original amount when you fill the form), and not the displayed amount in the payment page

Edit: Issue for this here

@wanlingt wanlingt merged commit 77edf16 into release-al2 May 8, 2023
@wanlingt wanlingt deleted the release_v6.47.0 branch May 8, 2023 05:33
This was referenced May 8, 2023
Closed
Open
@wanlingt wanlingt mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foochifa foochifa foochifa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wanlingt @foochifa @KenLSM @justynoh