-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: playwright tests cancelled after timeout #6208
Conversation
dd48e70
to
7a428df
Compare
c876aa1
to
63a9a8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh btw the changes here corrects the retrieving of OTP emails a bit:
return inbox.filter(filterFn).sort((a, b) => a.time - b.time)
^this corrects the sorting of emails to ascending order of time! so that we can get the latest email when we use pop
(not sure why this bug has survived so long?? maybe because we've just been deleting all the other emails)
await MAIL_CLIENT.deleteById(lastEmail.id)
^I removed the deleting of emails by client because... I don't think its needed? and its easier for debugging if we have all the emails in the inbox
…into fix/playwright
- reduce wait timeout for popup modals to appear
Closing in favour of a clean PR at #6308 |
Problem
Playwright tests are wonky and we want to fix them (to some extent) so we can at least have some e2e tests!
Closes #6154
Solution
Fixed several bugs in the playwright tests:
getRoleBy
combobox when using dropdown for field settings (done in 87c5a40).fillMultiDropdown
issues:Issues left to tackle regarding playwright tests:
encrypt-submission
playwright test suite #6307For future reference when playwright tests timeout, here is the estimated time taken for a successful run of tests on GitHub Actions (as of this PR):
login.spec.ts
(9 tests): ~ 1 minencrypt-submission.spec.ts
(15 tests): ~ 18 minemail-submission.spec.ts
(5 tests): ~ 10 minBreaking Changes
Features:
Improvements:
Bug Fixes: