Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitoring): add memory monitoring to EC2 instances #620

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

liangyuanruo
Copy link
Contributor

@liangyuanruo liangyuanruo commented Nov 11, 2020

Problem

EC2 memory monitoring was previously relying on an unofficial 3rd party solution, which at one point was working intermittently.

The problem has become more pressing since PR #555 was merged, which reported a 19 MB increase in memory usage for a single bulk download of 10,000 submissions.

Solution

Upgrade to use an official solution provided by AWS here, which provides both memory and disk monitoring. The only change made was to the cron expression, which has been updated to report every minute instead of every 5 minutes.

The requisite permissions have been granted to our Elastic Beanstalk instance profiles.

@liangyuanruo liangyuanruo marked this pull request as ready for review November 11, 2020 09:46
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but pls do create an issue and put the issue# in code so we can tag and change this when we update

.ebextensions/eb-memory-monitor.config Outdated Show resolved Hide resolved
@liangyuanruo liangyuanruo merged commit e0ba8f2 into develop Nov 16, 2020
@liangyuanruo liangyuanruo deleted the feat/memory branch November 16, 2020 03:51
@karrui karrui mentioned this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants