Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update payment guide in payment unsupported msg #6199

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

foochifa
Copy link
Contributor

@foochifa foochifa commented Apr 26, 2023

Problem

Payment guide has been updated, we can publish it now

Closes #6014

Solution

Update PaymentsUnsupportedMsg

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

AFTER:

image

Tests

  • go to an email mode form. Go to settings, make sure that the settings page is as seen in the screenshot
  • go to the payment guide link, make sure that it can open

@LinHuiqing
Copy link
Contributor

Just to double check, are these the right links for the guide? it goes https://go.gov.sg/formsg-guide-payments -> https://app.tango.us/app/workflow/Creating-payment-forms-2eb9521debdf41fe8152f78052286059
Screenshot 2023-04-26 at 11 57 21 AM

Was a bit thrown off by the Tango logo haha

Copy link
Contributor

@LinHuiqing LinHuiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested! Approving since the link is to the go.gov.sg link, and my comments are on the guide link and the guide itself.

@LinHuiqing
Copy link
Contributor

@kennethchangOPENGOV some other comments on the guide itself:

  1. We can consider shifting the opening of the form down or excluding these steps since we want to block payment-related changes from being made when the form is open in the future, right?

Screenshot 2023-04-26 at 12 03 22 PM

  1. There's an untitled step here:

Screenshot 2023-04-26 at 12 00 05 PM

@LinHuiqing
Copy link
Contributor

Merge when we're sure we're ready to publish the guide considering the above comments bah^

@kennethchangOPENGOV
Copy link

made amendments

@LinHuiqing LinHuiqing merged commit f347d22 into develop Apr 26, 2023
@LinHuiqing LinHuiqing deleted the chore/update-payment-guide-in-unsupported-msg branch April 26, 2023 04:52
@LinHuiqing LinHuiqing mentioned this pull request Apr 26, 2023
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Payments Guide link after guide is created
3 participants