-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: payment mvp #6095
Merged
Merged
feat: payment mvp #6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fix to reference correct schema field id mapping
* fix: add submission id to metadata and update receipt payment description * feat: consistent submission id * chore: clarify receipt description form * chore: switch order of fields in submission * chore: remove unnecessary typecheck * test: add tests for stable submission id flow * chore: update tests with correct valuse
* feat: perform post-submission actions when payment is completed * feat: delete email responses from payment document * chore: remove responses field from shared payment type
* feat: add processing, canceled state * refactor: move edgecase ui up * refactor: rename enum pending to pendingpayment * hide feedbackblock on feedback submission, remove feedbackblock on processing * refactor: cleanup, simplify, and comments for stripe payment elements * refactor: rename files * chore: string literals to not use curly braces in props * refactor: add guard clause to check if form exists
* add type hint on populatedForm * fix: add handling of undefined properties
* fix: update subtitle for payment received message block * fix: amend copy again
…e dates (#6132) * fix: convert from seconds to miliseconds from epoch when saving Stripe dates * test: update test data
…t field is disabled (#6130) * feat: disable description and amount fields for admin when the payment field is disabled * chore: update copy for some payment drawer fields * test: update tests * chore: update model
* fix: update payment page to include submission ID * chore: rename props * fix: update payment page to include submission ID * chore: rename props
feat: check form on first proceed to pay
LinHuiqing
force-pushed
the
feat/payment-mvp
branch
from
April 19, 2023 09:59
579864c
to
30e3395
Compare
timotheeg
approved these changes
Apr 19, 2023
This was referenced Apr 19, 2023
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging payment epic into develop for payment launch!