ref: migrate fetch form submission counts flow to Typescript

src/app/controllers/submissions.server.controller.js

@@ -1,16 +1,9 @@
 'use strict'
 
 const axios = require('axios')
-
-const mongoose = require('mongoose')
-const errorHandler = require('../utils/handle-mongo-error')
-const getSubmissionModel = require('../models/submission.server.model').default
-const Submission = getSubmissionModel(mongoose)
-
 const { StatusCodes } = require('http-status-codes')
 
 const { createReqMeta } = require('../utils/request')
-const { isMalformedDate, createQueryWithDateParam } = require('../utils/date')
 const logger = require('../../config/logger').createLoggerWithLabel(module)
 const MailService = require('../services/mail/mail.service').default
 
@@ -190,52 +183,6 @@ const sendEmailAutoReplies = async function (req) {
   }
 }
 
-/**
- * Count number of form submissions for Results tab
- * @param  {Object} req - Express request object
- * @param  {String} [req.query.startDate] Optional date query parameter in YYYY-MM-DD format. Assumes GMT+8.
- * @param  {String} [req.query.endDate] Optional date query parameter in YYYY-MM-DD format. Assumes GMT+8.
- * @param  {Object} res - Express response object
- */
-exports.count = function (req, res) {
-  let query = { form: req.form._id }
-
-  if (
-    isMalformedDate(req.query.startDate) ||
-    isMalformedDate(req.query.endDate)
-  ) {
-    return res.status(StatusCodes.BAD_REQUEST).json({
-      message: 'Malformed date parameter',
-    })
-  }
-
-  const augmentedQuery = createQueryWithDateParam(
-    req.query.startDate,
-    req.query.endDate,
-  )
-
-  query = { ...query, ...augmentedQuery }
-
-  Submission.countDocuments(query, function (err, count) {
-    if (err) {
-      logger.error({
-        message: 'Error counting submission documents from database',
-        meta: {
-          action: 'count',
-          ...createReqMeta(req),
-        },
-        error: err,
-      })
-
-      return res.status(StatusCodes.INTERNAL_SERVER_ERROR).json({
-        message: errorHandler.getMongoErrorMessage(err),
-      })
-    } else {
-      return res.json(count)
-    }
-  })
-}
-
 exports.sendAutoReply = function (req, res) {
   const { form, submission } = req
   // Return the reply early to the submitter

src/app/modules/auth/auth.utils.ts

@@ -55,3 +55,10 @@ export const isUserInSession = (
 ): session is Express.AuthedSession => {
   return !!session?.user?._id
 }
+
+// TODO(#212): Save userId instead of entire user collection in session.
+export const getUserIdFromSession = (
+  session?: Express.Session,
+): string | undefined => {
+  return session?.user?._id as string | undefined
+}

src/app/modules/core/core.errors.ts

@@ -32,3 +32,8 @@ export class DatabaseError extends ApplicationError {
     super(message)
   }
 }
+export class MalformedParametersError extends ApplicationError {
+  constructor(message: string) {
+    super(message)
+  }
+}