fix: meta tags for public form pages #5799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Social media previews were not being generated correctly for public forms.
formResult.value.status
wasundefined
asstatus
was not retrieved in the form result. Hence the check for public forms was always returningfalse
, and the default meta tags would be used for public forms, instead of the public form-specific meta tags.Closes #5589
Solution
To fix this, I specified
status
when retrieving the form usingFormService.retrieveFormKeysById
.Breaking Changes
Before & After Screenshots
AFTER:
Public form
Private form
Tests
Preview and generate Open Graph meta tags, check that
title
,description
andimage
are populated for