Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ogp logo svgr #5749

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: ogp logo svgr #5749

merged 1 commit into from
Feb 13, 2023

Conversation

justynoh
Copy link
Contributor

@justynoh justynoh commented Feb 13, 2023 •
edited
Loading

Problem

Currently, the OGP logo svgr in the app footer gets cut off (the 'T' is dead). This PR fixes that.

Closes #5748

Solution

Remove masks from the path groups in the SVGR.

Breaking Changes

  • No - this PR is backwards compatible

Screenshots

Left: chrome, Right: firefox

Screenshot 2023-02-13 at 10 21 00 AM

@justynoh justynoh requested a review from wanlingt February 13, 2023 02:30
wanlingt
wanlingt approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@wanlingt wanlingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:o

@justynoh justynoh merged commit 08a1589 into develop Feb 13, 2023
@justynoh justynoh deleted the fix/ogp-logo-svgr branch February 13, 2023 03:10
@justynoh justynoh mentioned this pull request Feb 15, 2023
Merged
@karrui
Copy link
Contributor

karrui commented Mar 9, 2023

Oh i know why this happens. Using SVGR means they assign ids to the mask groups, starting from a, to b, ... etc. But when there are two SVGR components, the IDs may clash. We should take a look at all the SVG React components to name the mask ids something less likely to clash....

@karrui karrui mentioned this pull request Mar 9, 2023
Open
@justynoh
Copy link
Contributor Author

justynoh commented Mar 9, 2023

what motivated you to look at this again LOL

@karrui
Copy link
Contributor

karrui commented Mar 9, 2023

what motivated you to look at this again LOL

Reading working doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanlingt wanlingt wanlingt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox: OGP logo in app footer gets cut off
3 participants
@justynoh @karrui @wanlingt